fix: resolve high severity string escaping vulnerabilities in build configuration#16
Merged
Merged
Conversation
This commit addresses 7 security and quality alerts reported by CodeQL, primarily focusing on high-severity flaws in the build configuration. The fixes include: - **Security (High):** Enhanced CSS minification logic in `vite.config.js` and `vite.config.safe.js` to properly escape backslashes before backticks, resolving 5 alerts related to 'Incomplete string escaping or encoding'. - **Security (Medium):** Addressed 'Inclusion of functionality from an untrusted source' found in `demo/index.html`. - **Quality (Warning):** Updated `baseScale` initialization in `src/spotlight.js` to resolve 'Useless assignment to local variable'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses 7 security and quality alerts reported by CodeQL, primarily focusing on high-severity flaws in the build configuration.
The fixes include:
vite.config.jsandvite.config.safe.jsto properly escape backslashes before backticks, resolving 5 alerts related to 'Incomplete string escaping or encoding'.demo/index.html.baseScaleinitialization insrc/spotlight.jsto resolve 'Useless assignment to local variable'.