Skip to content

make check fails two tests related to cloexec #198

Description

@dpreed

I just downloaded the current version of blink, and after configure and make, it fails two of the tests in 'make check'.

The tests are the test/libc/calls/closefrom_test.c on line 62, where fcntl returns 1 instead of 0 and the test/libc/calls/dup_test.c on line 81, where the messages says dup_clearsCloexecFlag doesn't happen.

I just deleted those lines from the comsmopolitan libc test makefile, and everything else works.

But this seems problematic.

Does blink deliberately violate the spec on dup clearing the cloexec flag? I presume cosmopolitan libc is not where the bug is.

I could do a fix if I know what the right fix is.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions