Fix LZCNT returning the BSR result - #216
Open
egorich239 wants to merge 1 commit into
Open
egorich239 wants to merge 1 commit into
egorich239 wants to merge 1 commit into
Conversation
REP BSR is LZCNT, but its helper answered bsr(x), the index of the highest set bit, where the count of zeros above it is wanted. The two helpers were also named the other way round: the one under REP BSF computes tzcnt and was called Lzcnt. They now carry the name of what they compute, and LZCNT answers bits - 1 - bsr(x). Flags are as they were: CF for a zero source, ZF for a zero result.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REP BSR is LZCNT, but its helper answered bsr(x), the index of the highest set bit, where the count of zeros above it is wanted. The two helpers were also named the other way round: the one under REP BSF computes tzcnt and was called Lzcnt. They now carry the name of what they compute, and LZCNT answers bits - 1 - bsr(x). Flags are as they were: CF for a zero source, ZF for a zero result.