Open
Conversation
Collaborator
|
Can you reset it to its original value afterward? Also, I'm not sure how I feel about a test being run conditionally based on the environment. |
Collaborator
Author
|
It's part of the test suite, do you really think its necessary to reset it afterwards? |
Collaborator
|
I know it's not necessary to reset it, but I think it's best to try to make the tests as independent as possible. |
package.json
Outdated
Contributor
There was a problem hiding this comment.
Did phantomjs finally get Function#bind?
Collaborator
Author
There was a problem hiding this comment.
doesn't look like it I probably should revert that change
Collaborator
|
@megawac rebase? |
Collaborator
|
Only meaningful if #2845 gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some coverage of the shimmed bind