Skip to content

chore(web): rebuild embedded dashboard assets#16

Draft
jasonmassie01 wants to merge 1 commit intomasterfrom
chore/rebuild-web-dist
Draft

chore(web): rebuild embedded dashboard assets#16
jasonmassie01 wants to merge 1 commit intomasterfrom
chore/rebuild-web-dist

Conversation

@jasonmassie01
Copy link
Copy Markdown
Owner

Summary

  • Regenerated sidecar/internal/api/dist bundle via npm ci && npm run build
  • Replaces stale asset hash (index-iTMDAwLc.jsindex-D4n6uqgg.js) and updates index.html reference
  • No logic changes; purely a build artifact refresh required for the go:embed target to compile

Test plan

  • Verify go build ./... succeeds in sidecar/ with the new dist files
  • Spot-check the dashboard loads correctly in a browser

https://claude.ai/code/session_01TQEUcWhqTHsD35FoxpcjCx


Generated by Claude Code

Regenerated dist bundle from npm run build; replaces stale asset hash.

https://claude.ai/code/session_01TQEUcWhqTHsD35FoxpcjCx
Copy link
Copy Markdown
Owner Author

pg-sage auto-review v1

Summary

Pure build artifact refresh: renames the content-hashed JS bundle (index-iTMDAwLc.jsindex-D4n6uqgg.js, 99% similarity via npm ci && npm run build) and updates the go:embed-targeted index.html to reference the new hash. No Go source files, no CSS file hash, and no logic changed. As a side effect, index.html line endings were normalized from CRLF to LF throughout, and a stray double-carriage-return on the <div id="root"> line (\r\r\n) was corrected.

Findings

Critical (0)

Warning (1)

  • sidecar/internal/api/dist/ + index.htmlMerge conflict risk with PR chore(deps): patch+minor dependency updates 2026-04-27 #8. Both PRs are open against master and touch the same files (index.html, the dist JS). PR chore(deps): patch+minor dependency updates 2026-04-27 #8 renames a different base JS hash (index-ecBLX5R2.jsindex-BaBRJ8Oe.js) and also changes the CSS hash; this PR starts from index-iTMDAwLc.js. These builds diverged from different states of master, so merging one will require a rebase/rebuild before the other can land. Recommend deciding merge order and rebuilding the second PR on top of the merged result.

Nit (1)

  • sidecar/internal/api/dist/index.html — CRLF → LF normalization and the \r\r\n fix are a welcome cleanup, but they are a side effect of the build machine's npm run build rather than an intentional change. Consider adding a .gitattributes entry (sidecar/internal/api/dist/index.html text eol=lf) to enforce LF going forward and prevent future noise in diffs.

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants