Skip to content

decode plotly directly when writing it to json #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vandenman wants to merge 2 commits into
base: master
Choose a base branch
from
Open

decode plotly directly when writing it to json #208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ca6bce
decode plotly directly when writing it to json
vandenman Jun 17, 2026
8e12655
avoid double json pass
vandenman Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions R/writeImage.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,11 @@ writeImageJaspResults <- function(plot, width = 320, height = 320, obj = TRUE, r
if (image[["interactive"]] )
tryCatch(
{
jsonOrTryError <- jaspGraphs::convertGgplotToPlotly(plot)
plotlyOrTryError <- jaspGraphs::convertGgplotToPlotly(plot, returnJSON = FALSE)

if (exists(".fromRCPP")) {
if (isTryError(jsonOrTryError)) {
image[["interactiveConvertError"]] = gettextf("The following error occured while converting a ggplot to plotly: %s", .extractErrorMessage(jsonOrTryError))
if (isTryError(plotlyOrTryError)) {
image[["interactiveConvertError"]] = gettextf("The following error occured while converting a ggplot to plotly: %s", .extractErrorMessage(plotlyOrTryError))
} else {

if (!is.null(relativePathJson) && nzchar(relativePathJson)) {
Expand All @@ -141,7 +141,7 @@ writeImageJaspResults <- function(plot, width = 320, height = 320, obj = TRUE, r
fullPathPlotly <- paste(locationPlotly$root, locationPlotly$relativePath, sep="/")
plotlyJsonFile <- file(fullPathPlotly)
on.exit(close(plotlyJsonFile), add = TRUE)
writeLines(jsonOrTryError, plotlyJsonFile)
writeLines(.plotlyToJson(plotlyOrTryError), plotlyJsonFile)

if(file.exists(fullPathPlotly)) {
image[["interactiveJsonData"]] <- locationPlotly$relativePath
Expand All @@ -161,6 +161,29 @@ writeImageJaspResults <- function(plot, width = 320, height = 320, obj = TRUE, r
return(image)
}

.plotlyToJson <- function(convertedPlotly) {
plotlyJson <- list(
data = convertedPlotly$plotly$x$data,
layout = convertedPlotly$plotly$x$layout,
hasRangeFrame = convertedPlotly$hasRangeFrame
)

toJSON(.decodeJsonLike(plotlyJson))
}

.decodeJsonLike <- function(x) {
if (is.character(x)) {
x <- decodeColNames(x)
} else if (is.list(x)) {
x[] <- lapply(x, .decodeJsonLike)
}

if (!is.null(names(x)))
names(x) <- decodeColNames(names(x))

x
}

# intentionally not exported
decodeplot <- function(x, ...) {
UseMethod("decodeplot", x)
Expand Down
Loading