cleanup#450
Conversation
|
build builder bot build for glory |
|
I was going through the jasp files and found this. no idea if that is because of your PR: |
juliuspfadt
left a comment
There was a problem hiding this comment.
See above. I am a bit lost as to how to review this, I checked the .jasp files and did some minor clicking around. I would still have some Ai review this, other than that it seems fine.
Review summaryVerified the "no behavior change" claim both empirically (ran the test suite, root-caused the one failure) and structurally (diffed every one of the ~800 top-level functions' old body vs. new body across all 8 file families, via parallel review). Test results: Behavior-preservation audit: All 8 file families (bayesianmetaanalysisdeprecated, classicalmetaanalysis, classicalmetaanalysismultilevelmultivariate, forestplot, robustbayesianmetaanalysis, funnelplot/effectsizecomputation/selectionmodels, predictionperformance+misc) checked out clean — no dropped functions, no duplicated definitions anywhere in the repo, no style regressions. The genuine consolidations ( Minor, non-blocking nits:
Recommendation: Approve. Well-executed, verified behavior-preserving refactor. Suggest one final clean |
|
Yeah, some of the meta-sem visualizations do not work (not a new issue) and shall be fixed in a later separate PR. The goal of this PR was just rearrange the files because they became too long which is inefficient for AI maintenance. |

Reorganized the R backend into smaller, purpose-specific files and consolidated duplicated helpers without changing analysis behavior or output.