Minor issues#475
Conversation
|
👋 Friendly reminder: It looks like If your changes include bug fixes, new features, or UI tweaks, please consider adding a quick note to the |
81d912d to
f5d46ea
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 84.96% 84.88% -0.08%
==========================================
Files 18 18
Lines 10012 10032 +20
==========================================
+ Hits 8507 8516 +9
- Misses 1505 1516 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
can you look into the copilot feedback @JTPetter? |
|
build builder bot build for glory |
✅ Build Complete!Your JASP module bundles have been successfully built for macOS (ARM) and Windows. 👉 Click here to download the artifacts (Scroll to the bottom of the page to find the "Artifacts" section). |
juliuspfadt
left a comment
There was a problem hiding this comment.
can you address the copilot feedback, then we can merge it
|
thanks, done! |
juliuspfadt
left a comment
There was a problem hiding this comment.
The new comments seem kind of valid... sorry.
|
@juliuspfadt No worries, thanks! I addressed them. |
|
with one of those other PRs you should probably take another run at fixing the unit tests... 😅 |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
juliuspfadt
left a comment
There was a problem hiding this comment.
given that the master unit tests dont fail, except macOs, maybe you can take the lock file from there? https://github.com/jasp-stats/jaspQualityControl/actions/runs/29020837963
|
@juliuspfadt good idea, thanks |
This PR fixes a bunch of minor issues: