Skip to content

Minor issues#475

Merged
JTPetter merged 7 commits into
jasp-stats:masterfrom
JTPetter:minorIssues
Jul 10, 2026
Merged

Minor issues#475
JTPetter merged 7 commits into
jasp-stats:masterfrom
JTPetter:minorIssues

Conversation

@JTPetter

Copy link
Copy Markdown
Contributor

This PR fixes a bunch of minor issues:

@github-actions

Copy link
Copy Markdown
Contributor

👋 Friendly reminder: It looks like NEWS.md wasn't updated in this Pull Request.

If your changes include bug fixes, new features, or UI tweaks, please consider adding a quick note to the # jaspYourModule (development version) section so our users know about your awesome work! (If this is just a minor typo fix, feel free to ignore this message.)

@JTPetter JTPetter force-pushed the minorIssues branch 2 times, most recently from 81d912d to f5d46ea Compare May 29, 2026 14:29
@codecov-commenter

codecov-commenter commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.60606% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.88%. Comparing base (8c33634) to head (d9d2f81).

Files with missing lines Patch % Lines
R/doeAnalysis.R 30.00% 7 Missing ⚠️
R/msaGaugeRRnonrep.R 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   84.96%   84.88%   -0.08%     
==========================================
  Files          18       18              
  Lines       10012    10032      +20     
==========================================
+ Hits         8507     8516       +9     
- Misses       1505     1516      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 30 changed files in this pull request and generated 2 comments.

Comment thread R/msaTestRetest.R Outdated
Comment thread R/doeAnalysis.R
@juliuspfadt

Copy link
Copy Markdown
Contributor

can you look into the copilot feedback @JTPetter?

@juliuspfadt

Copy link
Copy Markdown
Contributor

build builder bot build for glory

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

✅ Build Complete!

Your JASP module bundles have been successfully built for macOS (ARM) and Windows.

👉 Click here to download the artifacts

(Scroll to the bottom of the page to find the "Artifacts" section).

@juliuspfadt juliuspfadt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you address the copilot feedback, then we can merge it

@JTPetter

JTPetter commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

thanks, done!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 30 changed files in this pull request and generated 4 comments.

Comment thread R/msaGaugeRR.R Outdated
Comment thread R/doeAnalysis.R Outdated
Comment thread R/msaGaugeRR.R
Comment thread R/msaGaugeRR.R

@juliuspfadt juliuspfadt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new comments seem kind of valid... sorry.

@JTPetter

JTPetter commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@juliuspfadt No worries, thanks! I addressed them.

@JTPetter JTPetter requested a review from juliuspfadt July 7, 2026 14:40
@juliuspfadt

Copy link
Copy Markdown
Contributor

with one of those other PRs you should probably take another run at fixing the unit tests... 😅

JTPetter and others added 3 commits July 9, 2026 16:27
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@juliuspfadt juliuspfadt self-requested a review July 9, 2026 15:03

@juliuspfadt juliuspfadt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that the master unit tests dont fail, except macOs, maybe you can take the lock file from there? https://github.com/jasp-stats/jaspQualityControl/actions/runs/29020837963

@JTPetter

Copy link
Copy Markdown
Contributor Author

@juliuspfadt good idea, thanks

@JTPetter JTPetter requested a review from juliuspfadt July 10, 2026 13:35

@juliuspfadt juliuspfadt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look promising. you can merge this. Probably a good idea to do the same for the other PRs that are failing.

@JTPetter JTPetter merged commit d553edf into jasp-stats:master Jul 10, 2026
6 of 8 checks passed
@JTPetter JTPetter deleted the minorIssues branch July 10, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Legend text on Components of Variation plot is cut off (does not display completely)

5 participants