assignment Alfred DSouza#7
assignment Alfred DSouza#7dsouzaalfred wants to merge 1 commit intojavascripters-community:masterfrom
Conversation
akshaynaik404
left a comment
akshaynaik404
left a comment
There was a problem hiding this comment.
Use stateless functional components and prop-types wherever necessary.
| import OrderReview from './components/OrderReview/OrderReview'; | ||
| import NotFound from './components/NotFound/NotFound'; | ||
|
|
||
| import Header from './components/Header/header'; |
There was a problem hiding this comment.
A base filename should exactly match the name of its default export. More info
| import React, { Component } from 'react'; | ||
|
|
||
| class NotFound extends Component { | ||
| class Footer extends Component { |
There was a problem hiding this comment.
Use Stateless functional components when there's no state. Detailed Explanation
| render() { | ||
| return ( | ||
| <div> | ||
| <h1>Developer is sleeping</h1> |
There was a problem hiding this comment.
You can directly return <h1> tag instead of wrapping it in a <div>
| @@ -0,0 +1,21 @@ | |||
| import React, { Component } from 'react'; | |||
|
|
|||
| class UserDetails extends Component { | |||
There was a problem hiding this comment.
You can use stateless functional component here.
javascripters2015
left a comment
javascripters2015
left a comment
There was a problem hiding this comment.
Please update the README file with all the required instructions for setup the project
Rest of the things looks good as a first review of your code, please update the code according to code review comments.
3 participants
assignment Alfred DSouza