Assignment of react beginners training submission by [Krishna Kumar]. Made ema-john app.#8
Open
krishnuz wants to merge 1 commit intojavascripters-community:masterfrom
Conversation
krishnuz
changed the title
javascripters2015
requested review from
amite,
khan4019,
shaikhimran786 and
vinodsobale
javascripters2015
requested changes
Aug 15, 2017
Contributor
javascripters2015
left a comment
javascripters2015
left a comment
There was a problem hiding this comment.
Please follow best practices,
1> Use comment wherever necessary
2> Make code more readable
3> User small function names, don't use any inline javascript code in HTML code.
| <h2>Features</h2> | ||
| <ul> | ||
| { | ||
| item.features.map(feature => <li key={feature.description}>{feature.description}:{feature.value}</li>) |
Contributor
There was a problem hiding this comment.
Function too long , please make it readable.
user comments to understand the code implementation intent.
| </div> | ||
| } | ||
| </div> | ||
| <button onClick={this.addToCartHandler.bind(this)}>Add to cart</button> |
Contributor
There was a problem hiding this comment.
assign some method onClick instead of inline js code, follow good practices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.