Skip to content

fix(windows): remove remaining SYMLINK guards missed by #607 #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javi11 merged 1 commit into from
May 22, 2026
+0 −9
Merged

fix(windows): remove remaining SYMLINK guards missed by #607 #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions internal/config/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"log/slog"
"os"
"path/filepath"
"runtime"
"slices"
"strings"
"sync"
Expand Down Expand Up @@ -542,10 +541,6 @@ func (c *Config) Validate() error {
if !validStrategies[c.Import.ImportStrategy] {
return fmt.Errorf("import_strategy must be one of: NONE, SYMLINK, STRM")
}
if runtime.GOOS == "windows" && c.Import.ImportStrategy == ImportStrategySYMLINK {
return fmt.Errorf("import_strategy SYMLINK is not supported on Windows; use STRM instead")
}

// Validate import directory when strategy requires it
if c.Import.ImportStrategy == ImportStrategySYMLINK || c.Import.ImportStrategy == ImportStrategySTRM {
if c.Import.ImportDir == nil || *c.Import.ImportDir == "" {
Expand Down
4 changes: 0 additions & 4 deletions internal/health/library_sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"net/url"
"os"
"path/filepath"
"runtime"
"sort"
"strings"
"sync"
Expand Down Expand Up @@ -1185,9 +1184,6 @@ func updateSymlinkForMountChange(
}

// Create new symlink
if runtime.GOOS == "windows" {
return currentTarget, false, fmt.Errorf("symlinks are not supported on Windows")
}
if err := os.Symlink(newTarget, symlinkPath); err != nil {
slog.ErrorContext(ctx, "Failed to create updated symlink",
"path", symlinkPath,
Expand Down
Loading