fix(frontend): show save button when mount type is disabled#614
Merged
Conversation
The Save Configuration button was wrapped in a `mountType !== "none"` guard, so selecting the "Disabled" option hid the button completely and prevented users from disabling the mount through the UI (only by editing config.yaml or calling the API). The mountPath required-check is also relaxed for the disabled state since no path is needed there. Fixes #611
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #611 — selecting the Disabled mount type left the user with no
Save button, so the change could not be persisted through the UI (users
had to hand-edit
config.yamlor call the REST API).Root cause
In
MountConfigSection.tsxthe entire Save block was wrapped in
{mountType !== "none" && (...)}.Once "Disabled" was selected the block (and the button) disappeared.
The button was also disabled while
!mountPath, which has no meaningwhen the mount is disabled.
Change
mountType !== "none" && mountPathChanged(it only applies to an active mount).(mountType !== "none" && !mountPath)so an empty path no longer blocks saving the disabled state.No backend change needed —
mount_type: "none"is already accepted, and thesuccess toast already produces "Mount type set to disabled".
Test plan
cd frontend && bun run buildsucceeds.fuseorrclone) selected, click Disabled, confirm the dialog, and verify the Save button now appears and is enabled.