fix(config): unify library_sync_concurrency default to 5#617
Merged
Conversation
Consolidate three divergent defaults (sample: 1, accessor: 5, inline: 10) by routing both call sites through GetLibrarySyncConcurrency() and updating the sample config comment to match the accessor's default of 5. Fixes #616
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #616 — the
library_sync_concurrencydefault was inconsistent across three locations (sample comment said1, the accessor returned5, the inline fallbacks at the call sites used10).internal/health/library_sync.gonow route throughcfg.GetLibrarySyncConcurrency()instead of duplicating an inline<=0 → 10fallback.config.sample.yamlcomment updated fromdefault: 1todefault: 5to match the accessor.internal/config/accessors.go) is now the single source of truth, returning5when unset. This also aligns with the existing example indocs/docs/3. Configuration/health-monitoring.md.Test plan
go build ./internal/health/... ./internal/config/...— cleango vet ./internal/health/... ./internal/config/...— clean5(vs10) as the canonical default