feat(poster): bump nntppool to v4.11.1 and use PostHeaders.Date field#222
Merged
Conversation
Update nntppool from v4.10.1 to v4.11.1 which added a dedicated Date time.Time field to PostHeaders. Use that field directly instead of formatting the date string into Extra["Date"], letting the library handle RFC-compliant formatting internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nntppoolfrom v4.10.1 to v4.11.1Extra["Date"](pre-formatted string) and into the newPostHeaders.Date time.Timefield introduced in v4.11.1time.Now().UTC()if the field is zeroWhat changed
internal/poster/poster.go—postArticleWithBody:Reviewer notes
Behaviour is identical — the article date is still applied to every outgoing article. The only difference is that formatting is now delegated to the library, which is the idiomatic way per the v4.11.1
PostHeadersdocumentation.Test plan
go build ./internal/poster/...— cleango test ./internal/poster/...— all tests pass