Skip to content

fix(par2): fall back to article-size block when SliceSize exceeds file size #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javi11 merged 1 commit into from
Apr 29, 2026
Merged

fix(par2): fall back to article-size block when SliceSize exceeds file size #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/par2/par2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,13 @@ func (p *NativeExecutor) CreateInDirectory(ctx context.Context, files []fileinfo
// createPar2ForFile creates PAR2 files for a single input file in the given directory.
func (p *NativeExecutor) createPar2ForFile(ctx context.Context, file fileinfo.FileInfo, dirPath string) ([]string, error) {
var parBlockSize uint64
if p.cfg.SliceSize > 0 {
if p.cfg.SliceSize > 0 && uint64(p.cfg.SliceSize) <= file.Size {
parBlockSize = uint64(p.cfg.SliceSize)
} else {
// Configured SliceSize exceeds file size (or is unset): fall back to
// article-size-based calculation. Clamping SliceSize to ≈file.Size
// creates only 1-2 slices with a nearly-zero last slice, which triggers
// undefined behavior in the ParPar C SIMD backend on Linux x86_64 (AVX-512).
parBlockSize = calculateParBlockSize(file.Size, p.articleSize)
}
// Guard: block size must not exceed file size AND must be SIMD-aligned.
Expand Down
Loading