Query Synaptic Indicies Inside of .to_jax() instead of .step()#770
Open
alexpejovic wants to merge 5 commits into
Open
Query Synaptic Indicies Inside of .to_jax() instead of .step()#770alexpejovic wants to merge 5 commits into
alexpejovic wants to merge 5 commits into
Conversation
Contributor
|
|
583de1c to
de0d3cb
Compare
Contributor
Author
This would be great if all of
Maybe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following are some PR notes. Note the first note, this PR isn't ready to be merged until benchmarks have been run. The purpose of the early PR is to get code feedback.
is_integratable, but I recognize it is bad,I am open to suggestions!
to_jax()currently cannot be wrapped byif not self.is_integratable,since the line
values = values.at[self.base.nodes.index.to_numpy()].set(value)inside of
to_jax()ends up raising anUnexpectedTracerErrorwhen jitted.find a way to avoid the
TracerError.modules/base.pyis to ensure that testtest_view_attrspasses.