Skip to content

Fix eval.py incorrectly limiting evaluation frames to frame_rate #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix eval.py incorrectly limiting evaluation frames to frame_rate #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ def main():
print(f"Extracted a total of {total_gt_frames} frames from all GT videos")

# Get GT images for IQA evaluation
gt_images_for_iqa = extract_uniform_frames(str(gt_combined_dir), int(args.frame_rate))
gt_images_for_iqa = extract_uniform_frames(str(gt_combined_dir), total_gt_frames)

# Process each method
for method in methods:
Expand All @@ -511,7 +511,7 @@ def main():
print(f"Extracted a total of {total_method_frames} frames from all {method} videos")

# Get method frames for IQA evaluation
method_images_for_iqa = extract_uniform_frames(str(method_combined_dir), int(args.frame_rate))
method_images_for_iqa = extract_uniform_frames(str(method_combined_dir), total_method_frames)
method_frames_for_iqa = [cv2.imread(img_path) for img_path in method_images_for_iqa]

# Calculate IQA metrics (PSNR, SSIM, LPIPS)
Expand Down