Skip to content

fix: Restore thread-local stat writer in MockSharedArbitratorTest #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaylisde wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Restore thread-local stat writer in MockSharedArbitratorTest #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions velox/common/memory/tests/MockSharedArbitratorTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1977,7 +1977,7 @@ DEBUG_ONLY_TEST_F(

std::unordered_map<std::string, RuntimeMetric> runtimeStats;
auto statsWriter = std::make_unique<TestRuntimeStatWriter>(runtimeStats);
setThreadLocalRunTimeStatWriter(statsWriter.get());
RuntimeStatWriterScopeGuard statsWriterGuard(statsWriter.get());

localArbitrationOp->allocate(memoryPoolReservedCapacity);
// Inject some delay for global arbitration.
Expand Down Expand Up @@ -2111,7 +2111,7 @@ TEST_F(MockSharedArbitrationTest, globalArbitrationWithoutSpill) {

std::unordered_map<std::string, RuntimeMetric> runtimeStats;
auto statsWriter = std::make_unique<TestRuntimeStatWriter>(runtimeStats);
setThreadLocalRunTimeStatWriter(statsWriter.get());
RuntimeStatWriterScopeGuard statsWriterGuard(statsWriter.get());
triggerOp->allocate(memoryCapacity / 2);

ASSERT_EQ(
Expand Down Expand Up @@ -2166,7 +2166,7 @@ TEST_F(MockSharedArbitrationTest, globalArbitrationSmallParticipantLargeGrow) {

std::unordered_map<std::string, RuntimeMetric> runtimeStats;
auto statsWriter = std::make_unique<TestRuntimeStatWriter>(runtimeStats);
setThreadLocalRunTimeStatWriter(statsWriter.get());
RuntimeStatWriterScopeGuard statsWriterGuard(statsWriter.get());

// task0 has 256MB + 256MB (attempt) = 512MB in top abort capacity limit
// bucket, which shall be evaluated first, and hence killed by global
Expand Down
Loading