Open
Conversation
Author
|
Great tests btw, I just checked this again: https://github.com/jayy-lmao/sql-gen/actions/runs/16371103470/job/46350984033?pr=19#step:6:442 It seems like:
Probably need to find a way to have explicitly store them on their own variables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #20
Needs review, this is also more of a demonstration than a PR to confirm my assumptions related to the issue.
I haven't tested on INT2. But for INT4 it works...
I also don't know the impact of this PR on mysql yet, it does change some files related to mysql. But have tested on postgres on my setup (in that issue's repro) and it works (it generated files under src/models):
