Open
Conversation
Owner
|
Thanks for this! I like how you've gone about this- but now that you mention it I do wonder if public fields is actually a sensible default? I imagine there are probably more people in your same situation. How would you feel about that? |
Contributor
Author
|
I am not sure, after some research it seems the two points of view exist in the community. |
Owner
|
Happy for a public default then 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like my pure data structs to have public fields.
AFAIK, your crate make them by default private and there is no way to change that.
So, i have implemented a
-- public-fieldsflag that makes all structs fields prefixed withpub.I have tried to respect your project structure, which is very clean, btw.
I hope you will like it.