Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 14 14
Lines 855 855
Branches 90 90
=======================================
Hits 844 844
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philipcraig
approved these changes
Feb 16, 2026
Twon
approved these changes
Feb 16, 2026
Disable cppcoreguidelines-missing-std-forward check as it triggers for unnamed arguments (is this a bug?)
philipcraig
approved these changes
Feb 22, 2026
There was a problem hiding this comment.
Pull request overview
This pull request enables a comprehensive set of clang-tidy checks and addresses all identified issues in the test and minimal compilation files. The changes modernize code style, improve include organization, and ensure consistent use of C++ best practices.
Changes:
- Expanded .clang-tidy configuration to include bugprone, cppcoreguidelines, misc, modernize, portability, and readability checks
- Fixed code style issues in test files including pointer declarations, array initialization, override specifiers, and include organization
- Added NOLINT suppressions to minimal compilation verification files
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .clang-tidy | Significantly expanded enabled checks to include bugprone, cppcoreguidelines, misc, modernize, portability, and readability categories with specific reasonable exclusions |
| polymorphic_test.cc | Reorganized includes alphabetically, added missing includes, removed unused includes, initialized std::array with braces, added override keyword |
| indirect_test.cc | Reorganized includes alphabetically, added missing includes, removed unused includes, changed auto to auto* for pointer declarations, initialized std::array with braces |
| polymorphic.cc | Added NOLINT comment to header include in compilation verification file |
| polymorphic_cxx14.cc | Added NOLINT comment to header include in compilation verification file |
| polymorphic_no_vtable.cc | Added NOLINT comment to header include in compilation verification file |
| indirect.cc | Added NOLINT comment to header include in compilation verification file |
| indirect_cxx14.cc | Added NOLINT comment to header include in compilation verification file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.