Leave moved-from valueless after move and move assign when allocators don't compare equal#622
Conversation
3e37864 to
da3a1c6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 14 14
Lines 855 859 +4
Branches 90 90
=======================================
+ Hits 844 848 +4
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This looks great modulo some linter issues. I think that running pre-commit and adding |
9bc850a to
fdd30bd
Compare
This patch fixes this postcondition when allocators compare different.
This patch fixes this postcondition when allocators compare different.
fdd30bd to
d58038a
Compare
|
Thanks for the PR @jogerh Do you make use of |
Thank you for approving the PR! I am not using |
|
I'd be interested to see diffs if you are able to share. Thanks for the PRs! |
N5032 specifies that move constructors and move assignment operators should leave the moved-from object in a valueless state.
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/n5032.pdf
This patch fixes this when allocators don't compare equal