fix: Conan 2 compliance for CI, packaging, and publishing workflow#18
Merged
Conversation
Agent-Logs-Url: https://github.com/jbltx/TextMateLib/sessions/c47b1c01-70f0-415f-8301-6ef36cb79245 Co-authored-by: jbltx <1284323+jbltx@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jbltx
April 13, 2026 17:26
View session
Owner
|
… errors Agent-Logs-Url: https://github.com/jbltx/TextMateLib/sessions/a9530db8-612e-4b80-952e-c0a38f6b16f4 Co-authored-by: jbltx <1284323+jbltx@users.noreply.github.com>
Contributor
Author
|
... The linker failure was caused by two gaps in the Conan packaging:
Fixed in
|
jbltx
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conan 2 rejects
exports_sourcespatterns starting with.., breakingconan export/conan createfor this monorepo where thirdparty submodules live at../../thirdpartyrelative topackages/tml-cpp/. Additionally, the package lacked atest_package/, the generatedtml_export.hwas never installed, and the CI had no Conan validation step.conanfile.py../../thirdparty/rapidjson/*and../../thirdparty/oniguruma/*fromexports_sources(Conan 2 hard-rejects..patterns viacopy())export_sources()method to copy vendored submodules into the Conan cache using explicit absolutesrcpaths — this is the correct Conan 2 escape hatch for monoreposTHIRDPARTY_DIRresolution ingenerate(): usesource_folder/thirdpartywhen present (cache build fromconan create), fall back to../../thirdparty(localconan installflow)package_type = "library"CMakeLists.txtTHIRDPARTY_DIRCMake variable (defaults to../../thirdpartyfor bare CMake builds; Conan overrides viaCMakeToolchain)../../thirdpartyoccurrences with${THIRDPARTY_DIR}tml_export.htoinclude/tml/— previously missing, breaking consumers who includec_api.h(which does#include "tml_export.h")test_package/(new)Conan 2's
conan createexpects atest_package/to verify the installed package end-to-end:CI workflows
build-and-test.yml: addconan-testjob — installs Conan 2, detects profile, runsconan create packages/tml-cpp --build=missingfrom repo root (exercisesexport_sources()+test_package/)release.ymlpublish-conan: runconan createfrom repo root instead ofpackages/tml-cpp/; use Python to extract version fromconanfile.pyreliably; fix malformed regex character class in prior version-extraction script