Retry HTTP POSTs for WSMan connections#204
Open
1upbyte wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203 and #21 (?)
Heavily based on adityatelange/evil-winrm-py@1ee4f2e, except updated to the latest master.
In my limited testing (sending a command after a long wait + running a long command) this fix seems to work well. I have only really toyed with the synchronous version and the async was just a copy paste.
I'd love to do more through testing of this (network dropping, server being down, etc.) but the current test suite seems to be broken. I attempted an intial fix due to use of upload-artifacts@v3 in the workflow file, but then something else came up about openssh not being installed.