Add ability to pass through host to SSM#85
Add ability to pass through host to SSM#85burncitiesburn wants to merge 2 commits intojcberquist:masterfrom
Conversation
|
Thanks for this. I do have a couple of questions. I see you added the ability to specify the What was the reason for specifying |
Remove passing true for encodeURL. Testing shows its not needed.
|
Hey! I double checked my testing, and it appears that encodeUrl=true isn't required. I must have had a case when it didn't work, or I was doing something odd. The host in the settings is used when getHost is called as part of apiCall. I'm just updating the getHost function to match the one here. It's so that I can enable testing against localstack such as Previously passing "host" in the constructorArgs would be ignored by the ssm service. |
|
Thanks for the follow up. With regard to the settings for the host, I am referring specifically to the change made to |
|
I understand, apologies. I'll double check why I updated api.cfc with host. I'll get back to you. |
This allows passing through a custom host through to ssm to allow testing with localstack and similar.
This matches how the S3.cfc works.
This also fixes an issue when the SSM service doesn't return json back from the API