Foreign Key constrains prevent global recycle bin clearing

[cti-mguedelha]

Which jcdcdev.Umbraco.ReadingTime version are you using?

13.0.10

Which Umbraco version are you using? For example: 10.4.0 - don't just write v10

13.14.0

Bug summary

Currently the package hooks into 2 relevant notifications (ContentSaving and ContentDeleting)

However, when a site or a whole section of a site is deleted/moved to the recycle bin and fully erased from the bin as well, this does not seem to trigger individual ContentSaving or ContentDeleting notifications per node in the empty operation, it raises a global set of just ContentMovingToRecycleBin + EmptyingRecycleBin (relevant ones).

This then is not caught by the package and leads to a foreign key constraint violation when Umbraco attempts to delete the whole contents of the bin.

As far as I can see the current delete process for the contentsaving notification simply deletes the data from the DB and does nothing else, so I'm not sure if possibly, simply changing the nature of the constraint to CASCADE deleting in the readingtime table when the the values from the umbraco tables are deleted?

I do seem to see that in v14 and v17 the table seems to be deleted so it might conflict with the upgrade path, and if so I'd suggest an alternative

We'd watch for either of those 2 notifications (whichever might be best) and update/delete reading time entries accordingly in the respective tree of content (contentmovingtorecylebin might be the best one, but up for debate)

Thoughts?

Steps to reproduce

1. Have a content tree with say 5-10 nodes
2. Delete the whole content tree or part of it
3. Select "empty recycle bin" and verify the constrain error (MSSQL in my example's case, but might fail on SQLite too)

Expected result / actual result

Expected: all nodes are cleared from the recycle bin without issue
Actual: prevented from emptying recycle bin due to FK contraints

[jcdcdev]

Hi @cti-mguedelha, thanks for reaching out and reporting this issue!

"We'd watch for either of those 2 notifications (whichever might be best) and update/delete reading time entries accordingly in the respective tree of content (contentmovingtorecylebin might be the best one, but up for debate)"

I think this would be a good fix as it is fit for newer versions of Umbraco too (assuming this issue can be replicated in v17)

Are you interested in contributing this change? If so I would be delighted to welcome your contribution, otherwise I will put it on my backlog

[MiguelGuedelha]

Hey @jcdcdev

Not too sure on my availability/free-time this week so, if you manage to get around to it before next weekend, feel free to. Otherwise I'll prob try to have a stab at it this next saturday (06/06)

[MiguelGuedelha]

I think this would be a good fix as it is fit for newer versions of Umbraco too (assuming this issue can be replicated in v17)

I haven't tried on 17, although I'm not quite sure it would be a problem there as there seems to be a migration to completely drop the database from what I remember looking? If that is the case, and the reading time storage is no longer DB driven then this probably won't be reproducible in v17 (but can always look into it whenever I take a stab at it, and possibly try the fix on both v13 and v17)

[cti-mguedelha]

Closed by #204