feat: add Sobol sensitivity analysis to screen()#98
Merged
jc-macdonald merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
- Add method='sobol' to screen() using SALib.sample.sobol and SALib.analyze.sobol - Returns S1 (first-order) Sobol indices in the same format as Morris mu_star (dict of observable name -> array of importances) - Refactor screen() internals: extract _screen_morris and _screen_sobol helpers, move validation to top of screen() - Change unknown-method error from NotImplementedError to ValueError - 4 new Sobol tests, update 1 existing test for error type change Closes #76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Sobol variance-based sensitivity analysis as a second screening method in
screen()(#76).Changes
screen(..., method='sobol')now usesSALib.sample.sobolandSALib.analyze.soboldict[str, NDArray]with one value per factorn_trajectoriesparameter controls the base sample size N; total evaluations are N x (num_vars + 2)screen()internals: extracted_screen_morris()and_screen_sobol()helpersscreen()(shared by both methods)NotImplementedErrortoValueErrorTests
Closes #76