feat: add Constraint dataclass and feasibility filtering#99
Merged
jc-macdonald merged 1 commit intomainfrom Apr 17, 2026
Merged
feat: add Constraint dataclass and feasibility filtering#99jc-macdonald merged 1 commit intomainfrom
jc-macdonald merged 1 commit intomainfrom
Conversation
- Constraint(name, observable, op, threshold) with operator validation and a .check() method for scalar values - ResultsTable.feasible(constraints) returns a boolean mask over rows - feasibility_filter(constraints) creates a Phase.filter_fn-compatible callable that keeps only feasible designs - Exported Constraint and feasibility_filter from the public API - 17 new tests (Constraint creation, operator validation, all 6 ops, ResultsTable.feasible with single/multiple/annotation constraints, feasibility_filter standalone and inside a Study pipeline)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds constraint handling for feasibility filtering of designs (#74).
Changes
Constraintdataclass inprotocols.py: frozen dataclass withname,observable,op,threshold. Validates operator on construction (>=,<=,>,<,==,!=). Includes a.check(value)method for scalar tests.ResultsTable.feasible(constraints): returns a booleanNDArraymask —Truefor rows where all constraints are satisfied. Supports both observable and annotation columns.feasibility_filter(constraints)instudy.py: creates aPhase.filter_fn-compatible callable that keeps only feasible designs, enabling constraint-driven phase transitions.Constraintandfeasibility_filterfrom the public API.Example usage
Tests
Closes #74