Fix local flash to use custom 2.5MB partition table#38
Merged
Conversation
The CI workflow already passes --partition-table to espflash save-image (18a0cd5), but the local cargo runner was still using the default partition layout, causing flash failures for the 1.4MB firmware binary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The firmware binary is ~1.5MB, which exceeds the default ESP32 partition layout (1MB app). The CI workflow already passes --partition-table to espflash save-image (18a0cd5), but the local
cargo runner config was never updated to match. This caused cargo espflash flash to fail with image_too_big on every local flash attempt.
Test plan