Skip to content

Avoid retrying cancellation errors in retry_if_not_exception_type#630

Open
oaksprout wants to merge 2 commits intojd:mainfrom
oaksprout:fix-cancelled-error-retry
Open

Avoid retrying cancellation errors in retry_if_not_exception_type#630
oaksprout wants to merge 2 commits intojd:mainfrom
oaksprout:fix-cancelled-error-retry

Conversation

@oaksprout
Copy link

Summary

  • stop retry_if_not_exception_type from retrying control-flow BaseException subclasses
  • add a regression test for asyncio.wait_for(...) cancellation
  • add sync coverage so BaseException interruptions are not retried either

Testing

  • pytest -q

Closes #529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

retry_if_not_exception_type swallows asyncio.CancelledError

1 participant