Repository navigation
Add specialist roles and original code intelligence, media and experiment skills - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivered expansion
Implement the selected reusable ideas from the Graft, Codebase Memory MCP, OpenMontage, Agency Agents and Scientific Agent Skills review without vendoring their engines or skill bodies.
Eight original skills: Codebase Orientation; Code Index Qualification; Reference Video Analysis; Media Timeline Assembly; Shot Continuity Review; Specialist Role Composition; Engineering Experiment Analysis; Dataset Readiness Review. Each has task-specific procedures, original examples, limitations and three explicitly not-run agent-host scenarios.
Eight original role presets: Frontend Engineer, Go Backend Engineer, Architecture Reviewer, QA and Accessibility Reviewer, Security Reviewer, Research Analyst, Video Producer, Release Verifier. Roles reference canonical skills, list deliverables/context/non-goals and requested mode, and do not grant permissions or launch workers. Reviewer/analyst presets request read-only operation; actual authority remains with the host.
User-facing and executable changes
catalog/roles.jsonis canonical, with strict role validation and generatedroles.json/sitemap/build metadata.rolesandrole ROLEcommands using bounded source hashing, provenance and no-execution behavior. No new tool entry or installer.index,timeline,dataset, and descriptiveexperimentcommands. They check supplied records against selected local hashes and preserve incomplete evidence; they do not call index engines, render media, authenticate approvals or compute inferential statistics.Inventory: 121 entries / 112 original skills / 9 tools / 18 bundles / 15 categories, plus 8 separately counted roles. The 24 new scenario inputs bring the domain-input count to 318; they are not completed host evaluations.
Verification — passed
Final head
f7fb788a45739383179affdf9e1a2ffcda2306f2, tree50494e3e29e6556e78ecddc61bf21316e8bc0c85, tested as combined candidate0830020ec3d1975e0c721793ca2925ab1738e00dagainst main828f1101ae8ac6a0e91eaa7f08cd7c42d8ef9e61.Final toolkit validation and existing React fixture qualification completed successfully.
The first full validation exposed an unclosed Base layout in the new Roles directory. The markup was repaired, then the full canonical pipeline ran again successfully. No failing tests were removed or skipped. No dependencies or lockfiles were changed.
Actual demonstrations and limits
python3 examples/specialist-collection/demo.pyreads and modifies only owned disposable fixture files. It detects source-byte changes against a supplied index receipt and changed narration against timeline dependencies. It reports the fixed synthetic workload with baseline 3/3 accepted versus candidate 2/3, two complete timing pairs, explicit excluded task c, retry-inclusive paired differences of -4 and -12 milliseconds, and one unknown output-token cell. Those are hand-checkable fixture values, not evidence that any real agent or engine is faster.The 29 role tests exercise registry identity, canonical selections, modes, unsupported fields, path/symlink bounds, missing helpers, content hashes, Git provenance and actual CLI behavior. The 47 specialist tests cover supplied index freshness/coverage/expected probes, frame timeline coverage/trims/assets/dependencies, exact CSV units/schema/workload/attempt identity, retries, failures, null metrics, unchanged source and CLI statuses.
Browser and visual evidence
Existing Playwright automation ran desktop Chromium 1440×1000 and iPhone 13-sized Chromium emulation. The final journey clicks home → Roles → Architecture Reviewer → Code Index Qualification → Code Intelligence and Orientation, with canonical source links and skill-to-role backlinks. Role search, URL restoration, empty/reset states, keyboard focus/activation, light theme, no-JavaScript discovery, all eight role routes, sitemap, new skill pages and extended bundle selections passed alongside existing regressions.
The final production-build screenshots were inspected for desktop/mobile Roles, light-theme Roles, and the mobile Architecture Reviewer contract. The existing dark/light lime design is retained; the header wraps on mobile, cards and role-contract columns stack, and inspected views showed no clipping or overlap. Document-overflow assertions passed. This is not Safari, physical-device, assistive-technology or actual agent-host certification.
Final build/browser artifact was downloaded and ZIP SHA-256 verified as
4357174ddf24b50d29f53a188b4de2a97bc0450ec7a2edc1c3a56eb59a8bc12dbefore inspection. The embedded Playwright report confirms 70 expected results, zero unexpected/flaky/skipped; build-info identifies the exact combined candidate and complete inventory above.Preserved boundaries
No Graft, Codebase Memory MCP, OpenMontage, Agency Agents, K-Dense, new renderer or statistics package was installed or copied. The research record links pinned sources. There is no new scheduler or human-authored KB duplicate, root dependency/lock change or original-content license decision.
Index checking validates a supplied receipt and known expected probe results, not runtime index authenticity or exhaustive coverage. Timeline checking is a bounded local cut-only contract, not a render, decoded-frame analysis, visual continuity check or permission verification. The skills describe additional actual-host work required for those claims. Experiment summaries retain all tasks and explicit excluded pairs but calculate descriptive paired execution-time aggregates only: no p-values, population confidence, causal claim or adoption decision. Requested role mode does not sandbox a worker.
No private DriftGate/AvatarOps repository, configuration, data or internal MCP changed. No paid service, credentials or live agent execution. Temporary transfer/export workflows and patch fragments are absent from the final tree.
Contracts:
docs/ROLES.md,docs/SPECIALIST_COLLECTION.md. Research:docs/research/CODE_ROLES_MEDIA_METHODS.md.After the approved merge, main validation and Pages deployment must pass; the deployment verifies the exact public revision, role inventory, category/bundle membership and representative new/existing pages before publication is reported complete.