Fix oauth2 list client search crashing#532
Merged
Merged
Conversation
'oauth2 list --search-client-name' crashed with an AttributeError (objects.file instead of objects.filter) and both search branches used the invalid '__ilike' lookup, which raises FieldError for --search-client-id. Use filter() with '__icontains' (the Django equivalent of SQL ILIKE substring matching) and report a not-found search on stderr instead of relying on the dead DoesNotExist handler (filter() never raises it). Adds regression tests for oauth2 list and both search options. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AgWqnQ8ExYjdZofXbvJZEz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'oauth2 list --search-client-name' crashed with an AttributeError (objects.file instead of objects.filter) and both search branches used the invalid '__ilike' lookup, which raises FieldError for --search-client-id. Use filter() with '__icontains' (the Django equivalent of SQL ILIKE substring matching) and report a not-found search on stderr instead of relying on the dead DoesNotExist handler (filter() never raises it).
Adds regression tests for oauth2 list and both search options.
Claude-Session: https://claude.ai/code/session_01AgWqnQ8ExYjdZofXbvJZEz