Skip to content

ci: GitHub Actions pipeline + zero lint errors - #1

Merged
jdluu merged 2 commits into
mainfrom
refactor/solid-foundation
Aug 26, 2026
Merged

ci: GitHub Actions pipeline + zero lint errors#1
jdluu merged 2 commits into
mainfrom
refactor/solid-foundation

Conversation

@jdluu

@jdluu jdluu commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds .github/workflows/ci.yml: lint / unit tests (with JUnit report) / debug APK build jobs on every PR and main push. This is the repo's first CI.
  • Fixes all 21 pre-existing lint errors so the lint job gates from day one:
    • SuspiciousIndentation in BottomNavigation.kt
    • 20 LocalContextGetResourceValueCall errors fixed idiomatically by hoisting resource resolution into composition (stringResource at composable scope, collectAsStateWithLifecycle for dynamic snackbar messages). No @Suppress, no behavior change.

Test Plan

  • ./gradlew lintDebug → 0 errors (was 21)
  • ./gradlew testDebugUnitTest → 25/25 pass
  • ./gradlew assembleDebug → success
  • CI jobs green on this PR

Part of the comprehensive refactor plan (docs/plans/2026-08-25-comprehensive-refactor.md), Phase 0.

jdluu added 2 commits August 25, 2026 17:16
- Add ci.yml with lint, unit-test (JUnit report), and APK build jobs
- Fix SuspiciousIndentation in BottomNavigation
- Fix 20 LocalContextGetResourceValueCall errors by hoisting string
  resolution into composition in MainActivity, PlannerScreen,
  SettingsScreen; behavior preserved
@jdluu
jdluu merged commit 9ccb267 into main Aug 26, 2026
3 checks passed
@jdluu
jdluu deleted the refactor/solid-foundation branch August 26, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant