refactor: repository SRP split + data/mapper extraction - #4
Merged
Conversation
- Move API/entity-to-domain mapping from inline extension functions in model files into dedicated pure mapper objects (data/mapper/): WorkoutMapper, RoutineMapper, ExerciseMapper - Split WorkoutRepositoryImpl (525 lines) into WorkoutQueryRepository and WorkoutMutationRepository behind an unchanged WorkoutRepository facade; ViewModels and use cases untouched - Same read/write split for StatsRepositoryImpl -> StatsQueryRepository + StatsMutationRepository - Add 19 mapper unit tests; all 268 pre-existing tests pass unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 of the refactor plan.
data/mapper/package: all API/entity-to-domain mapping extracted verbatim from model extension functions into WorkoutMapper / RoutineMapper / ExerciseMapper - models are now plain data classesWorkoutQueryRepository,WorkoutMutationRepository), old interface preserved as a delegating facade so zero ViewModel/use-case changesTest Plan