refactor: AI prompt extraction + narrow sync/API-key interfaces - #5
Merged
Conversation
- Move all prompt assembly from HevyAiDataAccessor into a pure domain/ai/PromptBuilder (no Android imports); accessor now only fetches data and delegates formatting. Output strings byte-identical. - Extract ApiKeyStatusSource, ManualSyncScheduler, SyncCompleteListener interfaces so AITrainerViewModel depends on abstractions instead of ApiKeyManager/SyncManager/SyncCoordinator concrete classes; bound in new SyncModule Hilt module. - Add PromptBuilder characterization tests (20) and AITrainerViewModel Turbine state tests (11); suite grows to 318 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 of the refactor plan (AI layer extensibility).
domain/ai/PromptBuilder: all prompt assembly extracted from HevyAiDataAccessor as a pure class (no Android imports). The accessor keeps data-fetching/failure-isolation only (SRP). Output verified byte-identical against the pre-refactor implementation, including formatWeight truncation (102 kg) and RPE rendering (@RPE8.0).ApiKeyStatusSource,ManualSyncScheduler,SyncCompleteListenerinstead of three concrete framework-tied classes - each faked in unit tests without WorkManager or encrypted storage. Bound via new SyncModule.Test Plan