Skip to content

test: stabilize offline library snapshot coverage #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdluu merged 1 commit into from
Aug 29, 2026
Merged

test: stabilize offline library snapshot coverage #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/__tests__/features/opds/useOfflineLibraryState.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,22 +163,28 @@ describe("useOfflineLibraryState", () => {
);
});

it("updates the snapshot and does not toast on success, preserving prior state on failure", async () => {
it("updates the snapshot and preserves prior state when a later refresh fails", async () => {
const { result } = renderOfflineState();
await waitFor(() => {
expect(mockList).toHaveBeenCalledTimes(1);
expect(result.current.libraryInfoByPublicationId["book-1"]?.primary?.revision_id).toBe(11);
});

expect(result.current.libraryInfoByPublicationId["book-1"]?.primary?.revision_id).toBe(11);
expect(mockNotify).not.toHaveBeenCalled();
mockNotify.mockClear();
mockList.mockRejectedValueOnce(new Error("Snapshot read failed"));

result.current.refreshLibrarySnapshot();
await waitFor(() => {
expect(mockList).toHaveBeenCalledTimes(2);
await act(async () => {
await result.current.refreshLibrarySnapshot();
});

expect(result.current.libraryInfoByPublicationId["book-1"]?.primary?.revision_id).toBe(11);
expect(mockNotify).not.toHaveBeenCalled();
expect(mockNotify).toHaveBeenCalledWith(
expect.objectContaining({ message: "Snapshot read failed" }),
{
context: "Offline library",
fallback: "Failed to load the offline library",
},
);
});
});

Expand Down
Loading