Skip to content

Review Juan Daniel Castrellon #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanDango wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Review Juan Daniel Castrellon #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,14 @@ <h3> Volleyball</h3>
</footer>

</div>
<p>Review: Me parece una página muy buena, solo tengo un problema y es que, al visualizar el contenido en pantalla completa
luego de la tarjeta donde se encuentra tu nombre, foto y esas cosas, queda un espacio negro que no se ve bien. Siento que
debería haber más contenido allí, o que el contenido que se encuentra debajo de la tarjeta llene llene completamente la pantalla
de izquierda a derecha.
Al pasar el código por el verificador de html encontré que dos warnings, pero no me parecieron pertinentes, pues indican que
deberías incluir un título al iniciar todos los articles y sections.
</p>

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script>
<script src="js/bootstrap.js"></script>
</body>
Expand Down