Skip to content

chore: remove pinned rust toolchain - #1235

Open
jdx wants to merge 2 commits into
mainfrom
chore/remove-rust-toolchain
Open

chore: remove pinned rust toolchain#1235
jdx wants to merge 2 commits into
mainfrom
chore/remove-rust-toolchain

Conversation

@jdx

@jdx jdx commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove rust-toolchain.toml
  • let development, CI, and release environments use their configured default Rust toolchain
  • use CI to expose any incompatibilities with the runner-provided compiler and Clippy

Validation

  • git diff --check
  • confirmed this environment selects its default stable toolchain, Rust 1.97.1, after removal

AI-assisted — Tool: Codex; model: openai/unavailable; version: unavailable.


Note

Low Risk
Configuration-only change with no application logic impact; the main effect is less reproducibility of local Rust versions across contributors.

Overview
Removes the repo-level rust-toolchain.toml that pinned Rust 1.95.0 and required clippy and rustfmt components.

Local builds and any environment that relied on that file will no longer auto-select that toolchain; they will use whatever Rust version is already configured (e.g. default stable on the machine or in CI). CI workflows that set toolchain explicitly are unchanged by this diff.

Reviewed by Cursor Bugbot for commit 2a9c040. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Chores
    • Removed the project’s pinned Rust toolchain configuration.
    • Rust tooling will now follow the environment’s default version and available formatting and linting tools.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d0ea76b-9294-4b80-9aac-5da27165ec01

📥 Commits

Reviewing files that changed from the base of the PR and between 5d5a94d and 29a8e7c.

📒 Files selected for processing (1)
  • rust-toolchain.toml
💤 Files with no reviewable changes (1)
  • rust-toolchain.toml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The pull request deletes rust-toolchain.toml. The repository no longer pins Rust to version 1.95.0 or declares default clippy and rustfmt components.

Changes

Rust toolchain configuration

Layer / File(s) Summary
Remove pinned Rust toolchain
rust-toolchain.toml
Deletes the Rust 1.95.0 channel configuration and its clippy and rustfmt component declarations.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 29a8e

This change only removes the repository-level Rust toolchain pin; no actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit found the toolchain file gone
No pinned Rust channel to carry on
Clippy and rustfmt hop free
The build now chooses its decree
Ears twitch in configuration dawn

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the pinned Rust toolchain configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the repository-level Rust 1.95.0 toolchain pin so development, CI, and release processes use their configured toolchains.

  • Deletes rust-toolchain.toml.
  • Removes automatic installation and selection of the pinned compiler, Clippy, and rustfmt.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
rust-toolchain.toml Deletes the Rust 1.95.0 toolchain configuration and its Clippy and rustfmt component declarations; no eligible follow-up defect was identified.

Reviews (2): Last reviewed commit: "Merge branch 'main' into chore/remove-ru..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Instruction counts

benchmark trend instructions Δ wall (min) Δ
builtins ▁▁▂▁▂▁▁▁▂▂▂▂▂▂▂▂█ 1,990,070 → 2,018,168 +1.41% ⚠️ 3.04 → 2.81ms -7.52%
check 21.29 → 19.74ms -7.27%
usage ███▇█▇▇▇████████▁ 4,650,080 → 4,610,452 -0.85% 3.35 → 3.52ms +5.16%
validate 5.02 → 4.81ms -4.26%

1 benchmark(s) above the 1% gate: builtins +1.41%

Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.

Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.

2a9c040976f5 vs c2066beb4a0c · measured on the runner, not pushed to the history.

@jdx
jdx enabled auto-merge (squash) August 26, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant