refactor(config)!: remove pkl CLI fallback - #1270
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR makes the built-in pklr evaluator the sole configuration runtime and provides an explicit migration error for the removed backend selector.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issues identified. The evaluator, environment, cache, dependency, test, and documentation changes consistently remove backend selection and retain a single pklr configuration path with explicit migration handling. Important Files Changed
Reviews (1): Last reviewed commit: "refactor(config)!: remove pkl CLI fallba..." | Re-trigger Greptile |
Instruction countsNothing was compared, and so nothing was gated. No series appears on both sides: either the base has no measurements recorded, or the two were measured on different runner classes, which are deliberately not comparable — counts shift between machine types by more than a real regression does. New, nothing to compare against: Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
Summary
Stack
Testing
AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Medium Risk
Config evaluation is a core startup path; removing the CLI fallback is a breaking v2 behavior change, though pklr was already the default and migration errors are explicit.
Overview
hk v2 always evaluates
hk.pkl(and global config) with the built-in pklr evaluator. The optional pkl CLI path,mise x -- pklfallback,HK_PKL_BACKEND, and theshell-wordsdependency are removed; settingHK_PKL_BACKENDnow fails fast with v2 migration text.Config loading and import analysis always go through pklr. Resolved-config caching no longer keys on backend choice (
with_cache_keyremoved). Docs and migration guide describe pklr-only runtime and reframeHK_PKL_*vars as pklr settings rather than pkl CLI flags.Bats tests drop pkl-backend selection cases and add coverage for rejecting
HK_PKL_BACKEND.Reviewed by Cursor Bugbot for commit 16c163f. Bugbot is set up for automated code reviews on this repo. Configure here.