Skip to content

feat(oracle-graalvm): resurrect oracle-graalvm with new JSON endpoint - #525

Merged
roele merged 1 commit into
mainfrom
issues/oracle-graalvm
Aug 3, 2026
Merged

feat(oracle-graalvm): resurrect oracle-graalvm with new JSON endpoint#525
roele merged 1 commit into
mainfrom
issues/oracle-graalvm

Conversation

@roele

@roele roele commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added Oracle GraalVM as a supported Java distribution.
    • Added release metadata retrieval for GraalVM Core packages, including version, platform, architecture, and checksum details.
    • Enterprise and innovation releases are excluded from available results.
    • Improved support for parsing modern GraalVM JDK package names.

Copilot AI review requested due to automatic review settings August 3, 2026 18:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds Oracle GraalVM as a JVM vendor. The implementation fetches Oracle release metadata, filters supported packages, parses modern archive names, records checksums, and registers the vendor globally.

Changes

Oracle GraalVM support

Layer / File(s) Summary
Release metadata and filename parsing
src/jvm/vendor/oracle_graalvm.rs
Defines release response models and parses supported Linux, macOS, and Windows archive names for x64 and aarch64 builds. Tests cover valid and invalid names.
Release retrieval and JVM mapping
src/jvm/vendor/oracle_graalvm.rs
Fetches release data in parallel, excludes Enterprise and innovation entries, processes Core packages, normalizes metadata, and records SHA256 checksums.
Global vendor registration
src/jvm/vendor/mod.rs
Publishes the Oracle GraalVM module and adds OracleGraalVM to the global vendor registry.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant VendorRegistry
  participant OracleGraalVM
  participant OracleReleaseIndex
  participant ReleaseMetadata
  VendorRegistry->>OracleGraalVM: invoke vendor implementation
  OracleGraalVM->>OracleReleaseIndex: fetch release index
  OracleGraalVM->>ReleaseMetadata: fetch release metadata in parallel
  OracleGraalVM->>OracleGraalVM: map Core packages into JvmData
Loading

Suggested reviewers: copilot

Poem

A rabbit hops through release rows bright,
Parses each archive left and right.
Core builds bloom with checksums neat,
Enterprise entries face retreat.
GraalVM joins the vendor line—
A carrot toast to code so fine!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the addition of the Oracle GraalVM vendor implementation and its new JSON endpoint.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown

Greptile Summary

This PR restores the Oracle GraalVM vendor using Oracle’s JSON download index.

  • Registers oracle-graalvm in the JVM vendor list.
  • Fetches release metadata in parallel and maps Core archives into normalized JvmData records.
  • Adds filename parsing tests for supported operating systems and architectures.

Confidence Score: 5/5

The PR appears safe to merge with no concrete changed-code failure established.

The restored vendor follows existing normalization and partial-fetch conventions, and the investigated parsing, metadata mapping, and registration paths revealed no reachable contract violation.

Important Files Changed

Filename Overview
src/jvm/vendor/mod.rs Registers the restored Oracle GraalVM module and vendor implementation.
src/jvm/vendor/oracle_graalvm.rs Implements Oracle JSON metadata retrieval, release mapping, checksum handling, filename parsing, and focused parser tests.

Reviews (1): Last reviewed commit: "feat(oracle-graalvm): resurrect oracle-g..." | Re-trigger Greptile

@roele
roele merged commit 132ea6f into main Aug 3, 2026
4 of 5 checks passed
@roele
roele deleted the issues/oracle-graalvm branch August 3, 2026 18:43

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/jvm/vendor/oracle_graalvm.rs (1)

145-197: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add unit tests for map_file and map_release.

Only meta_from_name has test coverage. map_file (checksum extraction, innovation-release filtering) and map_release (Core package selection) contain pure logic that does not require network access, yet neither is covered by tests. Add tests that construct FileData/PackageData/ReleaseData values directly and assert on checksum extraction, innovation-release skipping, and Core-only filtering.

Also applies to: 233-305

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/jvm/vendor/oracle_graalvm.rs` around lines 145 - 197, Add unit tests for
map_file and map_release, constructing FileData, PackageData, and ReleaseData
directly without network access. Cover map_file checksum extraction and
innovation-release filtering, and cover map_release selecting only Core
packages. Reuse existing test helpers and assert the returned JvmData or
skipped/filtered results.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/jvm/vendor/oracle_graalvm.rs`:
- Around line 145-197: Add unit tests for map_file and map_release, constructing
FileData, PackageData, and ReleaseData directly without network access. Cover
map_file checksum extraction and innovation-release filtering, and cover
map_release selecting only Core packages. Reuse existing test helpers and assert
the returned JvmData or skipped/filtered results.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 6356f38c-f38e-446b-b23e-28159b7933bc

📥 Commits

Reviewing files that changed from the base of the PR and between 674659b and 5f99397.

📒 Files selected for processing (2)
  • src/jvm/vendor/mod.rs
  • src/jvm/vendor/oracle_graalvm.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants