Avoid regex errors when running on Windows.#28
Open
sjp wants to merge 1 commit intojeffreyhorner:masterfrom
sjp:master
Open
Avoid regex errors when running on Windows.#28sjp wants to merge 1 commit intojeffreyhorner:masterfrom sjp:master
sjp wants to merge 1 commit intojeffreyhorner:masterfrom
sjp:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
A user of one of my packages emailed me with the following error message:
This appeared to be caused by
.Platform$file.sepbeing a backref in regex-land when used on Windows (i.e..Platform$file.sepis\.I made a minor change so that there is a char vector substring match instead of a regular expression (should be faster too, not that it matters).
Unfortunately I was unable to test whether this fixes the problem (don't have a Windows machine handy), but it does not break anything in Linux anyway.