Create strings.xml for Chinese localization - #294
Conversation
Add Chinese (Simplified) localization for app strings.
The translation itself is complete — 317 strings and 9 plurals, exact key parity with `values/strings.xml`, every format specifier matching. What was missing is everything around it, because both translation gates in this repo take a hard-coded locale list and `values-zh` was in neither. It would have shipped without any check ever looking at it. - `ResourceParityTest` gains `values-zh` in the key-parity list. - `UntranslatedStringTest` gains `"zh"` in `LOCALES` and `"zh" to emptySet()` in `LANGUAGE_COINCIDENCES`. Both are needed: the map is read with `.getValue()`, so a locale without an entry throws instead of failing. `emptySet()` is right — the ten values identical to English are exactly `STRUCTURALLY_IDENTICAL`, same as ja and ko. - Drops `quantity="one"` from all 9 plurals. Chinese has only `other` in CLDR, so that item can never be selected; both items carried the same text and only the second was ever used. ko and ja, the other locales with no plural distinction, already ship `other` only. `raw-zh/starter_notes.md` is still missing, so a Chinese device falls back to the English sample notes on first launch. That is a working fallback, not a break, and `localizedStarterNotesExist` says in a comment why zh is absent from its list rather than leaving the gap to look like an oversight. Verified: ResourceParityTest and UntranslatedStringTest pass with zh registered; `:app:lintRelease` is green. The one lint warning on the new file is `TypographyEllipsis` on `search_notes_hint`, which the English source and values-ja/ko/es/fr all carry too. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Thank you — this is a genuinely careful piece of work, and it holds up to the checks I can actually run:
Rather than send you back and forth over repo plumbing you have no reason to know about, I pushed a follow-up commit to this branch. Three things, all of them our side of the fence:
Verified before pushing: both gate tests pass with One thing left, if you are willing
If you would like to take it, a separate PR is perfect. If not, that is completely fine — say so and I will find another way. The public side of Chinese support — landing page, privacy policy, README — is in #295, waiting on this one. You are credited in |
Add Chinese (Simplified) localization for app strings.