[WIP] Fix backwards compatibility in date formatting#296
Merged
Conversation
Co-authored-by: benbalter <282759+benbalter@users.noreply.github.com>
Copilot stopped work on behalf of
benbalter due to an error
December 5, 2025 01:27
Contributor
|
@copilot keep working |
Co-authored-by: benbalter <282759+benbalter@users.noreply.github.com>
Contributor
Author
Completed all remaining tasks:
The fix ensures Time objects are passed directly to Liquid instead of being converted to JSON strings, which allows date filters like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value#to_liquidmethod inlib/jekyll-github-metadata/value.rbdoes not handleTimeobjects properly - they fall through toto_jsonwhich can cause issues with date filter parsingValue#to_liquidmethod to includeTimein the case statement so Time objects are passed directly to LiquidSummary
This PR fixes a backwards compatibility issue with date formatting. The problem was that
Timeobjects were being converted to JSON strings viato_jsoninstead of being passed directly to Liquid's date filter.Before: Using
{{ site.github.updated_at | date: "%B %-d, %Y" }}could produce incorrect output likeJanuary %-29, 2025.After: Time objects are passed directly to Liquid, allowing date filters to work correctly and produce
January 29, 2025.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.