Implement work around for API fault regarding certain season types in the series endpoint#242
Open
iampegram wants to merge 1 commit into
Open
Implement work around for API fault regarding certain season types in the series endpoint#242iampegram wants to merge 1 commit into
iampegram wants to merge 1 commit into
Conversation
4 tasks
|
Can someone of the core/plugin team have a look? Since the API problem was reported nearly two years ago and no one of the TVDB Team reacted, I think we can assume that they wont fix it any time soon on the API side. |
… the series endpoint
Author
|
Well, one benefit of waiting so long is that I learned how to squash commits, so at least all my lack of proofreading commits won't pollute the timeline. Would it be uncouth to tag some of the maintainers in this? I imagine they get so many notifications it becomes white noise... |
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully works around thetvdb/v4-api#340 and fixes #226. Please forgive me if this code doesn't compile or looks terrible; I'm more of a Java/PHP/Python programmer... I know the underlying principle works because I've checked it against the API spec.
Sorry for all the extra commits... I need to proofread better.