ci: validate Renovate preset + JSON on PRs - #4
Merged
Conversation
.github inherits the org Renovate preset's patch+digest automerge rule but had no CI, so automerge here merged with no gate — and a malformed default.json silently breaks Renovate for the entire org. Add a check job that runs renovate-config-validator --strict on default.json and jq-validates every JSON file, satisfying the preset's stated contract that every extending repo have PR-triggered CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
default.jsonalready enables org-wide patch + digest automerge ("every repo that extends this default must have PR-triggered CI that exercises the dependency surface"). But.githubitself has no CI — so:.githubauto-merge with no gate, anddefault.jsonwould silently break Renovate for the entire org (every repo inherits this preset).Change
Add a
checkjob that runs on PRs:renovate-config-validator --strict renovate/default.json— catches a broken preset before it ships org-wide.jq-validates every JSON file in the repo.Verified locally: validator reports "Config validated successfully"; JSON check passes.
Follow-up
Once merged and the
checkcontext has reported once, add.github: { required_checks: ["check"] }to command-center'sconfig/branch-protection.jsonand reconcile viaprotect.sh --apply --only .github— so.githubautomerge is gated like every other repo.