Skip to content

Fix secondary promise timeouts#1237

Draft
drizzentic wants to merge 5 commits into
masterfrom
fix-secondary-promise-timeouts
Draft

Fix secondary promise timeouts#1237
drizzentic wants to merge 5 commits into
masterfrom
fix-secondary-promise-timeouts

Conversation

@drizzentic

Copy link
Copy Markdown
Collaborator

fix: resolve HTTP request timeouts and connection issues

This commit addresses several critical issues in the OpenHIM routing system:

  1. Fixed socket hangup errors by creating fresh connection agents for each request
  2. Resolved timeout issues by extending server socket timeouts and improving promise handling
  3. Added support for Brotli compression to handle all content encoding types
  4. Implemented robust error handling for secondary routes to prevent transaction failures
  5. Fixed duplicate requests by removing problematic await statements and properly chaining promises
  6. Added comprehensive logging for better diagnostics and troubleshooting
  7. Improved secondary route processing to ensure transactions complete even when routes fail

These changes significantly improve the reliability of the routing system,
particularly for secondary routes that depend on primary route responses.

@coderabbitai

coderabbitai Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d5992427-3c3c-4cd4-87b5-24f43747397e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-secondary-promise-timeouts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@drizzentic drizzentic force-pushed the fix-secondary-promise-timeouts branch from 5a4d908 to 03f727f Compare May 13, 2025 09:29
This commit addresses several critical issues in the OpenHIM routing system:

1. Fixed socket hangup errors by creating fresh connection agents for each request
2. Resolved timeout issues by extending server socket timeouts and improving promise handling
3. Added support for Brotli compression to handle all content encoding types
4. Implemented robust error handling for secondary routes to prevent transaction failures
5. Fixed duplicate requests by removing problematic await statements and properly chaining promises
6. Added comprehensive logging for better diagnostics and troubleshooting
7. Improved secondary route processing to ensure transactions complete even when routes fail

These changes significantly improve the reliability of the routing system,
particularly for secondary routes that depend on primary route responses.
@drizzentic drizzentic force-pushed the fix-secondary-promise-timeouts branch from 03f727f to 490aa1a Compare May 13, 2025 09:51
@drizzentic drizzentic force-pushed the fix-secondary-promise-timeouts branch from 9576f39 to 661593e Compare May 13, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant