WIP: Add unique index on endpoint method and pattern combo#143
Draft
MattyJ007 wants to merge 1 commit into
Draft
WIP: Add unique index on endpoint method and pattern combo#143MattyJ007 wants to merge 1 commit into
MattyJ007 wants to merge 1 commit into
Conversation
The mapping should allow multiple endpoints to be created with the same pattern if they work on different request methods. This is needed as logic for: GET /test vs POST /test PUT /test/:id vs DELETE /test/:id Are completely different yet their url path patterns are the same. The mapping mediator already caters to adding routes per HTTP Method DEB-8
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 97.16% 97.17% +0.01%
==========================================
Files 21 21
Lines 951 957 +6
==========================================
+ Hits 924 930 +6
Misses 27 27
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mapping should allow multiple endpoints to be created with the same
pattern if they work on different request methods. This is needed as
logic for:
GET /test vs POST /test
PUT /test/:id vs DELETE /test/:id
Are completely different yet their url path patterns are the same.
The mapping mediator already caters to adding routes per HTTP Method
DEB-8