Fix get_completed: remove await and use positional args#9
Open
HosomiKai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way completed tasks are fetched from the TickTick client in the
filter_tools.pymodule. The main change is switching from an asynchronous call to a synchronous call for retrieving completed tasks, and updating the argument format to use positional arguments.Task fetching logic update:
client.task.get_completedfrom an asynchronousawaitcall to a synchronous call and updated arguments to use positional parameters (start_dt,end_dt) instead of keyword arguments. (src/ticktick_mcp/tools/filter_tools.py)