mysql support, JenkinsBuidEnvinment satellite table added to data model

[sergueik]

re-adding accidentally closed pull request
Added mysql jdbc driver to the pom, updated pom to pull from http://repo.jenkins-ci.org/public/
Fixed defect in plugin causing packaging problem
Added JENKINS_BUILD_ENVIRONMENT model ( initial implementation : new database table, fields, reports)
Fixed the test errors

[martinda]

Has this pull request been abandoned? I want to add postgresql to this plugin, so having mysql as an example to follow would be great! Thanks.

[sergueik]

Hello Martinda
Hope you are doing well.

1.The original project owner has been quite busy when  I was active.
2. I was not been working on this code patch for quite some time due to other business that took priority.

The patch to support additional driver jars is very elementary. I think that I submitted something else which was not of interest, and my social coding skills are not perfect... and hence I did not manage to get it mainstream.
Do you have capacity to compile the custom version of plugin on your cluster and use it ? I can assist with the patch then.  I did it in house and know  many people do the same due to some friction in code reviews.

If you want otherwise, it may need to wait , I am preparing to a round of job interviews recently, entirely different technology domain.

Thanks,
Serguei Kouzmine

  From: martinda <notifications@github.com>

To: jenkinsci/audit2db-plugin audit2db-plugin@noreply.github.com
Cc: Serguei Kouzmine kouzmine_serguei@yahoo.com
Sent: Sunday, March 1, 2015 3:01 PM
Subject: Re: [audit2db-plugin] mysql support, JenkinsBuidEnvinment satellite table added to data model (#11)

Has this pull request been abandoned? I want to add postgresql to this plugin, so having mysql as an example to follow would be great! Thanks.—
Reply to this email directly or view it on GitHub.

[martinda]

No, I have not used the mysql version as it is the postgresql that I need to use in the end. I am able to compile the master branch here https://github.com/sergueik/audit2db-plugin. I see the commits of the pull request, but there is a lot of white space change taking place so I find it hard to see where the mysql support was really added. If you could point that out that would help me. Thank you.

I also see that Kohsuke added a base plugin for database access https://github.com/jenkinsci/database-postgresql-plugin

At this point I try to decide which way to go.

[sergueik]

Hello Martinda

Thanks for looking.
I beleive the postgressql should be very similar to mysql in effort of adding. I can look into it ...

Whitespace should not be a concern.
The feature I was adding is an additional hibrenate / persisstence class to collect envitonment of the job, but turns out while table is created the data is of moderate interest - I  am a heay user of envinhect plugin, this is why I  was doing this. I can segregate the changes.

Let me know if you need assistance
Serguei Kouzmine
From: martinda notifications@github.com
To: jenkinsci/audit2db-plugin audit2db-plugin@noreply.github.com
Cc: Serguei Kouzmine kouzmine_serguei@yahoo.com
Sent: Sunday, March 1, 2015 8:37 PM
Subject: Re: [audit2db-plugin] mysql support, JenkinsBuidEnvinment satellite table added to data model (#11)

No, I have not used the mysql version as it is the postgresql that I need to use in the end. I am able to compile the master branch here https://github.com/sergueik/audit2db-plugin. I see the commits of the pull request, but there is a lot of white space change taking place so I find it hard to see where the mysql support was really added.I also see that Kohsuke added a base plugin for database access https://github.com/jenkinsci/database-postgresql-pluginAt this point I try to decide which way to go.—
Reply to this email directly or view it on GitHub.

[sergueik]

Hello again Martinda
Let me iterate, the adding postgresql / mysql support is IIRC as easy as adding another pom dependency, with possibly no other code necessary, this is why i started with it.

If you are confused by sorting through commits let me know if I have a window of time to look i will (but there are some other items on the list.
Thanks for your interestSerguei Kouzine

  From: Kouzmine Serguei <kouzmine_serguei@yahoo.com>

To: jenkinsci/audit2db-plugin reply@reply.github.com; jenkinsci/audit2db-plugin audit2db-plugin@noreply.github.com
Sent: Sunday, March 1, 2015 9:03 PM
Subject: Re: [audit2db-plugin] mysql support, JenkinsBuidEnvinment satellite table added to data model (#11)

Hello Martinda

Thanks for looking.
I beleive the postgressql should be very similar to mysql in effort of adding. I can look into it ...

Whitespace should not be a concern.
The feature I was adding is an additional hibrenate / persisstence class to collect envitonment of the job, but turns out while table is created the data is of moderate interest - I  am a heay user of envinhect plugin, this is why I  was doing this. I can segregate the changes.

Let me know if you need assistance
Serguei Kouzmine

 From: martinda <notifications@github.com>

To: jenkinsci/audit2db-plugin audit2db-plugin@noreply.github.com
Cc: Serguei Kouzmine kouzmine_serguei@yahoo.com
Sent: Sunday, March 1, 2015 8:37 PM
Subject: Re: [audit2db-plugin] mysql support, JenkinsBuidEnvinment satellite table added to data model (#11)

No, I have not used the mysql version as it is the postgresql that I need to use in the end. I am able to compile the master branch here https://github.com/sergueik/audit2db-plugin. I see the commits of the pull request, but there is a lot of white space change taking place so I find it hard to see where the mysql support was really added.I also see that Kohsuke added a base plugin for database access https://github.com/jenkinsci/database-postgresql-pluginAt this point I try to decide which way to go.—
Reply to this email directly or view it on GitHub.