reduce scope of try-catch - #45
Open
frhanjav wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #25
Type of Change
The PR fixes an efficiency issue in the captureEvent(FlowNode node) method by reducing the scope of the try-catch block.
Previously, the entire chain of method calls was wrapped in a try-catch, but only
getExecutable()actually throws IOException.The solution extracts
node.getExecution().getOwner()out of the try-catch block and stores the result in a properly typed variable (FlowExecutionOwner owner), then only wraps theowner.getExecutable()call in the exception handling. This makes the code more readable and precisely identifies which operation might fail.The correct type was identified by consulting the Jenkins API documentation at:
https://javadoc.jenkins.io/plugin/workflow-api/org/jenkinsci/plugins/workflow/flow/FlowExecution.html
which shows that method
getOwner()returns aFlowExecutionOwnertype